FYI way/1524477498 crosses over a couple of bunkers.

Hi Davis,

There are a bunch of problems with your course edits and I wanted to point them out so that you can correct your mapping on future projects.

1. You're deleting other people's work. For instance, there are some green outlines that you deleted and then redrew from scratch. You should modify the existing paths unless it is impossible or extremely difficult to do. And if it's the latter, look into better tools like JOSM.
2. You are sharing fairway nodes with the far end of a green's nodes. This shouldn't be done. If there is no fringe, the fairway should butt up to the green and not go around the green.
3. You are creating multipolygons. That's great, but you are setting the tags on an outer member (typically a fairway) to the name tags on the multipolygon. That isn't correct. Look for any other golf course in the US and it should have correct tags on the multi, but not the outer member.

If you have any questions, please let me know. And visit the wiki for all sorts of useful information about mapping golf courses. You can find it at osm.wiki/

Thanks Frame,

But please make sure you don't intersect golf features. One of your water areas was overlapping a fairway on a golf course. The intersection of the two was declared as both water and grass at the same time. Instead, share the nodes at the boundary and adjust location as appropriate. Thanks.

Looks like it was part of changeset/180969802 and the other components of that "ecoregion" were deleted. This lingering way should have also be deleted, but was probably missed because they were only looking for the original mapper. I've gone ahead and deleted it. Thanks for letting me know.

RE: way/1521074656, et al

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green, along with the correct way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green, leaving room for the fringe. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two, and every node at the boundary needs to be shared, leaving no gaps. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you have any questions about golf course mapping, feel free to reach out. Thanks.

RE: way/1208146930

Hey maddog,

FYI, golf holes should trace the path of a typical shot through the air. Therefore, they shouldn't have intersecting nodes at every line they touch. Think of them as 3D where the fairway outline is on the ground, but the ball path is in the air.

This wiki might help as well: golf=hole

I've reverted this change. Please see the golf=hole mapping wiki for proper mapping of golf hole lines.

Hey there Hogmite,
I've removed these pins as that isn't the right way to map golf courses. Arbitrary markers like this to help you measure distances isn't an appropriate use of OSM.

Please don't put two nodes at the end of a golf=hole way like you did on the fourth hole. There only needs to be one. (I've corrected it this time.)

If you could point me to where you heard about doing this, I would appreciate it. I see this once and a while and I'd love to correct the original source of this misinformation on how to map out a hole. Thanks.

RE: way/1517767144, et al

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green, along with the correct way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green, leaving room for the fringe. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two, and every node at the boundary needs to be shared, leaving no gaps. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you have any questions about golf course mapping, feel free to reach out. Thanks.

You are creating multiple ways for the same path. You should modify existing ways or as a last resort, delete the previous way. But you don't want two lines describing the same thing. Thx.

FYI, you shouldn't "name" things like "proposed parking lot". You could put that in a description or a note or something other than "name". Thx

FYI,

Fairways and greens shouldn't overlap.

RE: way/1514850558, et al

As I mentioned in changeset/181789189, fairways and greens shouldn't be overlapping like this. Please make sure you read the wiki in my previous comments. If you have any questions, I'd be happy to help. Thx

RE: way/1513864319

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green, along with the correct way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green, leaving room for the fringe. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two, and every node at the boundary needs to be shared, leaving no gaps. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you have any questions about golf course mapping, feel free to reach out. Thanks.

Thanks for the report. I've been meaning to fix this for a couple years now: https://gitlab.com/b-jazz/https_all_the_things/-/work_items/8

It's raining today, maybe I'll poke at it a little bit and see if the fix is trivial.

FYI,

Golf course holes have a direction to them. Please make sure you start at a tee and draw the way towards the green.

Also, you might want to avoid making huge changesets that have a wide variety of edits in them.

Did your cat fall asleep on the keyboard while you were editing the 10th hole? A par 333333333333333312 is easily beatable, but there are no cute nicknames for 333333333333333309 under par.

RE: way/1511161316

When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the ways used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. If you could go back and clean up where you've made this mistake, that would be helpful. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions about golf course mapping, feel free to reach out.

I noticed that you used the word "spline" in your changeset. This particular use of the word often comes from some early videos on how to map golf courses and merge them with LIDAR to import into a video game. Please be aware that there are some bad examples in those videos on the proper way to map golf courses. Especially around intersecting ways.

Yeah, the iD editor isn't always the easiest to see what is going on. If you do a lot with relations/multipolygons, you'll have an even harder time. If you are going to get serious about golf course mapping, you might want to look in JOSM.