Thanks bbmiller. Looks like others have removed the entire relation but possibly left behind elements that weren't part of the original relation. Those have been cleaned up by others as well.

Hey there FOFB,

Thanks for cleaning up these bogus hole numbers (refs). Just curious how you found them. It's uncommon for someone with so few changes to be finding a specific error like that across a large area and fixing them up. Glad to have you around lending a hand!

Oh, if you continue doing this and see a name along with it that is just the hole number or something like "Hole 1", could you deleted that tag while you're there? Thx!

To be clear, this isn't the "current OSM convention" but is a proposed convention that hasn't been voted on.

There is one problem that I've noticed so far and that is that you took a multipolygon that describes a fairway as being made up of an outer polygon and the green as an inner polygon. You tagged that outer ring as "fairway", but that isn't correct as the definition of what is and isn't fairway belongs to the multipolygon relation. See osm.wiki/ID_understanding_golf_course_relations for more information.

Hey Stephen, there are ton of problems with your edits that you've made to this golf course. I don't even know where to begin fixing it. You've duplicate a bunch of information that already exists. cart paths, fairways, greens, water hazards, etc. You should go back through and clean them up. I'll check back in 48 hours.

You've also named items that shouldn't be named. Please read up the various golf related wiki pages at wiki.openstreetmap.org and look at how other courses are mapped to get an idea of community standards.

I see you are using JOSM, but I don't see that you validated your changes, because around a hundred ways have duplicate nodes in them that should have been caught (and fixed).

Another example is node/14019884508 that doesn't join the green way.

Hey Pizza,

Can you be a little more careful when joining fairways to greens like node/14020226043? I've fixed several of these in the past couple of weeks and thought it would be worth reaching out and mentioning it to see if you could correct it at the source.

Thanks,
- b-jazz

way/1539099360 and it's neighbor partially overlap, but map the same body of water. They should be represented with a single polygon and not two overlapping (or even adjoining) polygons. Can you please fix this? Thx.

Greetings mayman,

Can you help me understand what you are doing with way/1539164424 and way/1539164423 and why they are mapped the way they are mapped instead of a single polygon for the bunker?

Thanks.

Hey there HockeyPlayz,

I did some small edits to the tees you mapped in this change. It's not uncommon to find that people want to map something and then give it a name. So somebody will map a building, tell OSM it is a building, and then name it "Building".

So I've unnamed "Tee #1" and put a `ref=1` tag on the two tees so that map consumers will know that it is the first tee. No need for you to go back. Just letting you know in case you do further editing.

Thanks.

P.S. Are you doing Happy Gilmore drives at your local course with a username like that?

I reverted the changes made that overlap other golf features. Please reach out to me.

Thanks for understanding. I've gone through and removed most/all of the roughs and single trees that were marked as wood. You might want to look at the golf course mapping wiki at leisure=golf_course. That's a good start with a lot of subsections to explore.

As for mapping out roughs, I'm typically against doing it because they rarely have well defined borders. But that's just me.

Hello DJH,

I just wanted to give you a heads up that I'm planning on reverting most(all?) of the changes you've done to this course. There are a ton of problems and it would be easier to remove your changes and start from scratch than try to fix them all up.

I understand you put effort into this, so I wanted to work with you and give you advanced warning.

Some of the problems:
* the areas you drew for things like roughs are extremely minimal and blocky and aren't following natural landscape.
* your roughs often cross over other elements like fairways and cart paths.
* you are using natural=wood to define a single tree or two. you should be placing single trees in those cases.
* sometimes your natural=wood extends far beyond the visible area that trees are in.

If you have issues with the reverting of these changes, please let me know in the next 24 hours. Thanks.

Putting the various fairways together into a multipolygon isn't necessarily wrong, but this isn't done anywhere else in the country. They are already associated with each other by the ref number. I'm going to undo this grouping for now, but am open to discussing the issue if you feel strongly about it.

I'm always happy to help. Feel free to reach out with golf mapping questions any time.

You might want to peruse the golf wiki at leisure=golf_course for some basics on how to map golf courses. Be sure to click on each of the features and read up on those as well. For instance, I noticed one of your golf=hole centerlines today was pointed in the wrong direction. It should always go from the tee to the green. Direction matters for this type of way. (I already fixed it, but figured I'd point it out for any future mapping you might plan.)

Hi Ziggurath,

Thanks for your contributions to golf course mapping in OSM.

One thing to keep in mind is that you shouldn't overlap fairways like you did with way/1535259820. Instead, the existing fairway and the fringe fairway that you created should be merged into a single fairway.

I had to dig out the VA imagery to see that you weren't doing something totally crazy. Interesting modification to the area.

There is a problem with how you're drawing the fairway though. You are sharing nodes with the greens that are inside of the fairway. Topologically, this isn't a valid construct since there is a simpler representation of the fairway that would exclude the green instead.

I also noticed you are touching other objects like bunkers with the fairway, but aren't sharing all the nodes. You should either share all the nodes at the boundary, or none of them. See node/13987073240 for example.

Hey Khrymsyn,

Thanks for working to improve golf courses in OSM. Please be aware that golf features like greens, fairways, roughs, tees, bunkers, etc shouldn't overlap each other. I noticed several of them were in this change and I'm cleaning them up, but I'm hoping you avoid that in the future so others don't have to come behind you to clean it up. Thanks.

Your multipolygon changes here are wrong, am I'm trying to fix them up. You added a bunch of things like tees and fairways as "inner" relations to the golf course multi. This effectively says that they are EXCLUDED from the golf course area, which makes no sense. If this is confusing, please let me know.

Hey there Charles,

I cleaned up some errors in this changeset and wanted to let you know about the errors so that you can avoid them in the future. You have set up multipolygon relations between the fairways and greens, and that's just great. But then you took it a step too far and tagged the outer member of those multipolygons as a fairway, which isn't correct. Those tags belong to the relation instead of the outer polygon.

This might help explain it: osm.wiki/ID_understanding_golf_course_relations

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green, along with the correct way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green, leaving room for the fringe. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two, and every node at the boundary needs to be shared, leaving no gaps. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you have any questions about golf course mapping, feel free to reach out. Thanks.