OpenStreetMap logo OpenStreetMap

Changeset When Comment
182091193

RE: way/1107283827

Please don't overlap fairways and greens like you did on the hole mentioned above. I've cleaned it up and added the fringe around the green, but thought you'd want to know for future mapping. Thanks.

181963709

FYI, you're not creating multipolygons correctly. I'm not exactly sure how you're doing it. You should be selecting both the fairway and the green and the same time and merging them together. Somehow you are created TWO multipolygons with single members instead of ONE multipolygon with two members. Happy to help you figure this out.

181871977

RE: way/1504288758

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green, along with the correct way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green, leaving room for the fringe. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two, and every node at the boundary needs to be shared, leaving no gaps. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you have any questions about golf course mapping, feel free to reach out. Thanks.

181905583

For future edits, please be aware that direction matters on golf=hole lines. They should point from the tee to the green, not the other way around. Thanks.

181915423

Copied comments into original changeset (changeset/181423736).

Added a bug (https://gitlab.com/b-jazz/https_all_the_things/-/work_items/13) to the bot repo to exclude certain strings in URL params.

181423736

Hi! It looks like the website URL on way/1499962733 may have been copied from Google Maps (it contained Google tracking parameters). Please be careful not to copy information from Google into OpenStreetMap, as Google's data is copyrighted.

cc: @iandees

181789189

RE: way/1503484887 et al

When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the ways used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. If you could go back and clean up where you've made this mistake, that would be helpful. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions about golf course mapping, feel free to reach out.

181697849

I don't want to discourage you from mapping golf courses, but please spend a little more time and make the areas more closely map satellite imagery. These outlines look very janky. And you are overlapping things all over the place like the fairway that crosses over the tee box, the green that crosses over the bunker, the fairway that crosses over the rough. If you can't be more careful, it would be better if you'd just wait for someone else to get around to mapping the area.

181516479

Not sure what this is about:

way/1500883161

also, this bunker node is crossing into the fairway:

node/13741079692

161365128

Where are there nearly two identical streams around way/1351448946?

181393679

Reverted in changeset/181480961

181249222

RE: way/1498881000

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green, along with the correct way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green, leaving room for the fringe. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two, and every node at the boundary needs to be shared, leaving no gaps. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you have any questions about golf course mapping, feel free to reach out. Thanks.

181023679

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green, along with the correct way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green, leaving room for the fringe. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two, and every node at the boundary needs to be shared, leaving no gaps. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you have any questions about golf course mapping, feel free to reach out. Thanks.

180917809

And 1496737572/1496737571, 1496788849/1496788847 as well.

180917809

Hey maddog,

There are several ways in error in your edits yesterday. Check out 1496787872, 1496787850, 1496787839, 1496787857, and a bunch of cruft around 1496787868.

180651683

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green, along with the correct way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green, leaving room for the fringe. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two, and every node at the boundary needs to be shared, leaving no gaps. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you have any questions about golf course mapping, feel free to reach out. Thanks.

180692178

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green, along with the correct way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green, leaving room for the fringe. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two, and every node at the boundary needs to be shared, leaving no gaps. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you have any questions about golf course mapping, feel free to reach out. Thanks.

(You actually had correctly drawn holes in the area before, but you removed them and made them incorrect this time. I don't understand. Could you please fix them up? Thanks.)

180480452

RE: way/1493280026, et al

I mentioned this before in a previous change of yours. Please make sure you read and understand changeset comments and engage with others so you understand and don't continue to make mapping errors. Thanks.

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green, along with the correct way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green, leaving room for the fringe. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two, and every node at the boundary needs to be shared, leaving no gaps. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you have any questions about golf course mapping, feel free to reach out. Thanks.

176973101

Here's another request (repeat of changeset/163963219) to aim for segments with around 1500 nodes instead of your current 1800-2000 segments. Geofabriks QA tool triggers on anything over 1800 and I feel compelled to come in behind you and clean those up. If you shoot for something like 1500, or even 1750, there will be fewer segments in the multipolygons then when I come through and double the count by splitting 1800s into 900s. Thanks!

180431085

Hey Numac,

Your rough's are all over the place, crossing fairways, greens, cart paths and everything. I'm planning on deleting them in 24 hours, but wanted to give you a chance to clean them up first. Please let me know when you've fixed them up.