When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green, along with the correct way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green, leaving room for the fringe. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two, and every node at the boundary needs to be shared, leaving no gaps. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you have any questions about golf course mapping, feel free to reach out. Thanks.

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green, along with the correct way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green, leaving room for the fringe. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two, and every node at the boundary needs to be shared, leaving no gaps. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you have any questions about golf course mapping, feel free to reach out. Thanks.

(You actually had correctly drawn holes in the area before, but you removed them and made them incorrect this time. I don't understand. Could you please fix them up? Thanks.)

RE: way/1493280026, et al

I mentioned this before in a previous change of yours. Please make sure you read and understand changeset comments and engage with others so you understand and don't continue to make mapping errors. Thanks.

When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas must not cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green, along with the correct way. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green, leaving room for the fringe. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two, and every node at the boundary needs to be shared, leaving no gaps. When drawing these shared nodes, editors like iD (built into openstreetmap.org) will "snap" to an existing node if you get close enough. If you have any questions about golf course mapping, feel free to reach out. Thanks.

Here's another request (repeat of changeset/163963219) to aim for segments with around 1500 nodes instead of your current 1800-2000 segments. Geofabriks QA tool triggers on anything over 1800 and I feel compelled to come in behind you and clean those up. If you shoot for something like 1500, or even 1750, there will be fewer segments in the multipolygons then when I come through and double the count by splitting 1800s into 900s. Thanks!

Hey Numac,

Your rough's are all over the place, crossing fairways, greens, cart paths and everything. I'm planning on deleting them in 24 hours, but wanted to give you a chance to clean them up first. Please let me know when you've fixed them up.

Thanks for working on improving golf courses. Please make sure you aren't drawing greens and fairways in a way that they cross over each other like you did near one of the bunkers on the 17th hole. This sets of Q/A tools and requires others to come in and clean up your work. Thanks.

Thanks for reading the Wiki!! Love that.

Thanks for going back to clean up. Much appreciated. I did find a couple of near-fixes that you should be careful of going forward. See the area around node/10274269213 for an example of a fairway still crossing a green.

thanks again for your attention to this.

Please make sure fairways and greens don't intersect/overlap. Same can be said for the various other golf areas as well (tees, bunkers, water hazards, etc)

RE: way/1486374280 et al

Thanks for helping map golf courses. There are some problems with your edits however and your mapping process needs to be fixed going forward so you don't continue to step on the efforts of others. For starters, you should read the following wiki: osm.wiki/Keep_the_history on how important it is to *not* delete map elements when you should be modifying them instead. You break multipolygon relations when you delete something like a fairway that belongs to a relation only to redraw it and not properly add it back to the existing relation. You should also read the golf_course wiki (leisure=golf_course#Common_mapping_pitfalls) and the general wiki on how to properly work with multipolygons (osm.wiki/Relation:multipolygon#iD). Thanks.

Can you please go back and clean up all your fairways. They should not intersect or overlap with the green like you've done many times of the last few changes. Thanks.

RE: way/1488525955

When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the ways used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. If you could go back and clean up where you've made this mistake, that would be helpful. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. Please read the wiki for instructions and examples of how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls. If you have any questions about golf course mapping, feel free to reach out.

Be careful marking out "rough" areas. They shouldn't extend deep into the trees. They also shouldn't intersect/touch other golf areas (like fairways and tees). Thanks.

Please stop breaking golf courses by removing the multipolygons. What you are doing is not correct and is not appreciated when I have to come back over your changes and fix them up again. If you have problems with this, let's discuss it. Maybe I can help you understand your error. Thanks.

There's a gray area on when mapping a golf rough is really worthwhile. I couldn't find any difference between the grass inside your rough areas and outside your rough areas. Probably best just to leave them out at that point.

FYI, you don't need to put "area=yes" on a fairway.

Thanks for helping map golf courses. There are some problems with your edits however and your mapping process needs to be fixed going forward so you don't continue to step on the efforts of others. For starters, you should read the following wiki: osm.wiki/Keep_the_history on how important it is to *not* delete map elements when you should be modifying them instead. You break multipolygon relations when you delete something like a fairway that belongs to a relation only to redraw it and not properly add it back to the existing relation. You should also read the golf_course wiki (leisure=golf_course#Common_mapping_pitfalls) and the general wiki on how to properly work with multipolygons (osm.wiki/Relation:multipolygon#iD). Thanks.

Also, the fairway you added crosses over the green at one spot, where the previous one didn't. Please fix that as well. Thanks.

Check out https://imgur.com/a/J455xMc

That's a pretty drastic change in the shape of that water hole and I wasn't sure which one was newer, so I grabbed a couple of different sources (Bing vs. Mapbox, I think). I think the way it is currently drawn might be using older imagery.

Thoughts?

way/1487044185 still has a `golf=fairway` tag, which duplicated that tag on the relation/20304786 relation.

Semi-related side note: as you appear to be doing a lot of mapping, you might want to consider learning JOSM to do editing. It is so much easier to understand relations, once you get the hang of using JOSM. It's worth the time invested.

One example is way/1483289987/history.

And my apologies for the form-letter text above. You didn't come across something that existed, but that is very common so it is how I wrote that notification text.

You create a fairway multipolygon and tagged the relation correctly, but then you also added the fairway tag to the outer way as well. This was true for several fairways and roughs as well. When part of a relation, the fairway/rough tags go on the relation and not on the outer way.

Does that help clear it up? Please let me know so I can refine what I'm saying. It isn't a simple concept, but it's important.