OpenStreetMap logo OpenStreetMap

Changeset When Comment
64308176

Hello @braidrass and welcome to OpenStreetMap. Your contribution is appreciated. I noticed you asked for a review. Most of your addition looks just fine but I wanted to let you know about a feature to "square" the corners of things like buildings by selecting the line and hitting 'Shift-S' or right clicking the line and selecting the Square function. It will make sure all of the corners are 90 degrees, like most buildings are built with.
We hope you come back again.

64156870

Hi Franta, I noticed that your trail had man duplicate nodes. I'm curious to know what tools you used to upload the kml file. Maybe we can file some bugs against some tool to make sure it doesn't create the same exact node several times. I've fixed the trail already, so nothing else to do here.

64226941

What type of business is this?

63890023

Another: way/638755828

63890023

BTW, the way in question is way/638134323

63890023

If this is an ongoing process, you might want to consider adding a self-intersection check to the ways that are being drawn. I've noticed a couple of examples where the line crossed back over itself, which triggers various validation checks. If you load your change files into JOSM, one of the validation checks that is run before upload is a check for that error.

60472341

"It will be completely deleted when merged to the primary relation(s)."

Are you still planning on deleting this?

64097755

@nathanerogers, you might want to check out umap (http://umap.openstreetmap.fr/en/map/new/#17/45.56673/-122.62325). It will allow you to create a personal map with your checkpoints.

64097755

OK. I went ahead and deleted them. Sounds a bit like an orienteering class. I've wanted to get into that. Too bad I don't live close enough to join you for the exercise.

64097755

Hi @nathanerogers. Can you tell us a little more about these checkpoints. I'm not sure they really belong as part of the map, but maybe you can explain it more and we can help you set up appropriate tags. Thanks.

64065142

Hey there @cbeddow. Whatever you're using to create those closed ways is creating duplicate nodes. See https://tools.geofabrik.de/osmi/?view=geometry&lon=-108.50637&lat=45.81372&zoom=14&overlays=duplicate_node_in_way for some of them.

63961036

@Nakaner, maybe you can add a feature to only show actual errors (self intersecting ways, duplicate nodes, etc). Also, it would be helpful if OSMI could put some language in the pop-up for long segments saying that people shouldn't fix them.
As for the Bermuda Triangle, I reverted my change a day or two ago as the consensus seems to be to not fix this class of (non-)problem.

63961036

Some more discussion on the topic is taking place on the US Slack instance: https://osmus.slack.com/archives/C029HV951/p1540853913092600

63961036

From the OSM Inspector wiki page: "So while it might not be a "proper" solution its certainly pragmatic to make the segments shorter. Another problem is due to the current implementation of the OSM API: When requesting all objects inside a bounding box only nodes in this bounding box and ways having a node in this bounding box will be returned. (This is done because it is more efficient.) So the longer the segments are and the smaller the bounding box the bigger the chances that some object will not be returned from the API call and might not appear on the map."

63961036

Another reason for breaking these up is that any accidental moves of a way (to 0,0 for instance) would be masked by all of the other long segments that exist. If we segment the long ways, any mistakes that are made will be more likely to stick out rather than be obscured by many other valid long ways. So my argument is that you need to "clean" them all up in order for mistakes to stand out.

Also, thanks very much for the discussion. I appreciate the feedback.

63961036

IMHO, that makes complete sense for straight, smaller ways. But for massive ways it becomes a problem when the nodes that define the way are far outside of the bbox that you are querying for. You aren't aware that a way is traversing your work and that might cause an issue. It's one of the reasons OSM Inspector calls it out as a problem.

63959707

Thanks for contributing to OpenStreetMap. Just to let you know, there is a handy feature in iD that will "square" the buildings that you create. After you draw a circle, press 's' to make all of the corners be 90 degrees. Or you can right-click on the area and select the "Square" function that way.
Thanks again. We hope to see you continuing to add features to the map.

63917719

Blargh. Chose the wrong changeset comment again. Sorry. Should say, "Removing duplicate nodes".

63907602

Oops, got out of my rhythm. The changeset comment should be "Removing some duplicate nodes" and the source is "OSM Inspector"

63686879

For instance, see v1 of way/636085409 and nodes 5998800364 and 5998811585.