jmapb's Comments
| Changeset | When | Comment |
|---|---|---|
| 159885403 | Yeah that's the idea, so the corollary is: when adding a new poi, check for an existing node (maybe tagged with disused: or construction:, maybe shop=vacant, maybe just an address) before creating a new one. It's not always so clean -- sometimes there are multiple businesses in a single space, sometimes storefronts divide in half or absorb neighborhooding storefronts. But to the extent that we can map in a way that keeps the history intact, we should. |
|
| 159885403 | Howdy happy_raccoon & thanks for your work! Just so you know, it's best practice to avoid deleting closed businesses in order to help preserve the history of each location. Ideally we'd like to have a node that corresponds to a particular space and be able to tell from that node's history what businesses have opened and closed there. (See osm.wiki/Keep_the_history ) So instead of deleting, try marking the existing business as closed by using a lifecycle prefix -- in this case we'd change the tag from from amenity=bar to disused:amenity=bar. (See osm.wiki/Lifecycle_prefix ). I've restored this deleted node and marked it disused in changeset/160191911 ... happy mapping, jmapb |
|
| 158761656 | We use the cuisine tag to indicate that food is served, & what kind. This is often used for restaurants but can also be applied to shops that prepare food. I used cuisine=breakfast;sandwich (multiple values separated by a semicolon) for this shop. I also removed the fixme tag -- in general this isn't the best way to communicate with your fellow mappers. You can ask questions at community forums (https://community.openstreetmap.org) and there's also an active community on Slack that includes a NYC-specific channel #local-nyc (https://osmus.slack.com/archives/C4DPLAN3U). OSM also has some built-in discussion methods: direct messages to other mappers, changeset comments (like this), and map notes which allow public discussion about issues at a particular location. |
|
| 158761656 | Hi alpine_alpaca & welcome to OSM in NYC, great to see a new mapper on the scene! I was updating the Stuyvesant Gourmet Deli (node/3676993335) when I noticed the fixme tag that you added in this changeset, asking if shop=convenience is the correct tag for a bodega... and generally, yeah, I'd say it is. You might find some tagged in other ways -- maybe shop=deli or shop=greengrocer -- and those might be ok in specific circumstances. But shop=convenience is usually the best tag for a small shop that sells food & isn't any kind of specialty shop. |
|
| 100108383 | Howdy, just noticed this changeset from a few years back. The modifications to the four address nodes (2868660099, 2868661029, 2868661030, and 2868661036) are incorrect. Eg 2868661036, which had addr:housenumber=154-05, was changed to addr:housenumber=154 and addr:unit=5 was added. Hyphenated housenumber fields like 154-05 are a notorious feature of the addressing system in Queens. The entire string, including the dash char, is the correct housenumber. You can read more at https://nycplanning.github.io/Geosupport-UPG/chapters/chapterV/section02/ (search for "hyphenated house number".) So next time you're mapping in Queens be aware of this practice. Don't worry about fixing anything though -- it turns out this building only has a single address, so I added that to the building way and deleted the address nodes. Happy mapping, J |
|
| 156917953 | Thanks Mateusz -- I wasn't aware of those tags & iirc made this one up on the spot. I've retagged node/8446152255 as shop=esoteric. (My impression is that the term "new age" is a little out of fashion. I'm most accustomed to hearing it as a sarcastic pejorative, and haven't encountered any self-identified new agers in many years.) |
|
| 156461035 | PS ... actually node/2550057146 already changed to a craft shop, no longer disused |
|
| 156461035 | Howdy jhaluska80 -- I've just reverted this changeset in 156595039 A couple of things...
- Re the building footprints that you adjusted: In an area with mature(ish) mapping, remember that there's no guarantee that iD's default aerial imagery is better aligned than the existing mapped features. If you do feel there's sufficient reason to tweak buildings' alignment, please take care when the ones you're moving are attached to other buildings (very common in city blocks.) Otherwise the adjacent buildings will be distorted ( see the skewed footprints at https://overpass-api.de/achavi/?changeset=156461035 ) Thanks & happy mapping! |
|
| 151198572 | Just did some updates to the Drawing Center (way/249664327) and noticed you'd added wheelchair=no... they do have steps but there's also a sidewalk-level entrance, and the website (https://drawingcenter.org/visit) claims they have "accessible galleries, bookstore, and restroom facilities" |
|
| 153819213 | Hi, thanks for adding the opening hours of the Drawing Center. I was changing the hours into the standard format that we in OSM (documented at opening%20hours=* but the short version is that we use 24 hour time and two-letter day abbreviations) and I noticed a discrepancy between the hours you added and those listed on the Drawing Center's website.The website says they're open Thursdays but you wrote "Thursday Closed." I used the info from the website, but is the website wrong? |
|
| 146562800 | I clearly remember seeing a "no motorcycles" rule in place at one time, but I haven't been able to find it since. Was this signed at the cemetery? |
|
| 141401927 | Thanks for adding this path: way/1208651473 I just used it and saved a few minutes :) |
|
| 152588296 | (I also reopened the zoo!) |
|
| 152603444 | (changeset comment should have said "add address") |
|
| 149875715 | Howdy! On some intersection nodes eg node/11455767273 you've added crossing=traffic_signals but I'm not sure that's correct. This tag shouldn't be used unless there's a walk signal for pedestrians. As far as I know this intersection just has stop signs, not signals. |
|
| 149420271 | Hi isakavya -- the tag "access:conditional=no @(Mo-Fr 07:00-13:00) 07:00-13:00)" on the segment way/1268090833 that you created is badly formatted (mismatched parens). Your changset comment "added restriction for board is only for buses" doesn't exactly make sense either -- are you trying to say that this entire block of Lexington is bus only for those hours? Perhaps you noticed a restriction sign for the bus lane and thought it applied to the entire roadway? |
|
| 149223746 | Thanks! |
|
| 149395903 | Nah they didn't have one posted at all, good catch, fixed |
|
| 148569753 | Great, let me know if you need any help, or eyes on the ground. Happy mapping! |
|
| 148569753 | Hi kguenther24! I see you've been adding a lot of highway=pedestrian + area=yes polygons (& multipolygons) in downtown Brooklyn. Unfortunately the mapping methods you're using are causing errors in pedestrian routing. Examples: - From Columbia Heights down to Squibb Park (osm.org/directions?engine=fossgis_osrm_foot&route=40.70077%2C-73.99523%3B40.70088%2C-73.99548#map=19/40.70089/-73.99528):
- From Sands Street to the Manhattan Bridge walkway (osm.org/directions?engine=fossgis_osrm_foot&route=40.69988%2C-73.98712%3B40.70005%2C-73.98682): The route now follows way/1262001717 (added in this changeset) and jumps from ground level directly up to the bridge. This bypasses the stairs, which is especially bad because it impacts wheelchair and bicycle routing. (Bicycles aren't actually allowed here at the moment, of course.) Current screenshots are at https://jmapb.github.io/kguenther24/ in case the map changes before you read this. The underlying issue seems to be that you're using highway=pedestrian + area=yes tags to describe the shape of sidewalks and other linear footways. This is incorrect tagging because area=yes should only be used on a highway area if it can be navigated omnidirectionally -- that is, when a traveler can meaningfully move in any direction and enter and exit the area at any point where it connects to other highways. For linear (one way or two way) highways, you can use area:highway=* tags to map the area details. See area:highway=footway for sidewalks and other footways, area:highway=steps for stairs, and area:highway=pedestrian for linear pedestrian highways. These tags will allow the routing engines to process the highways as linear, which should keep these errors from happening. Thanks, jmapb |