OpenStreetMap logo OpenStreetMap

Changeset When Comment
123972121

Hey tsanren89,

Use good changeset comments, please. See
osm.wiki/Good_changeset_comments

When saving your changes, you can additionally add, under "source";
- "local knowledge" (if you have been there in the past); or
- "survey" (if you have been there recently)

Also, please reply to changeset comments. This way other contributors know you are reading them. You should get an email notification if you receive one.
There is one changeset comment you have not replied to;
changeset/122670359

Regards,

Daniel

39933336

Resolved by
changeset/123982789

123938348

You should exclude the static part of the URL, including "File:".

Note, the image was uploaded as PNG. It should preferably be an SVG. If you'd like to link to the PNG anyways, replace ".svg" by ".png" in the wiki:symbol tag.

When uploading the SVG, you'll have to upload it as a new file - you can not add it as an updated version of the PNG file, as different file formats are stored seperately on the wiki. (it will warn you if you try to do this.)

The full URL of the file on the wiki;
osm.wiki/File:MacGiollophadraig_Way.png
(Do not use this for the wiki:symbol tag)

123248846

From note/3263525

way/862406520/history

It looks like this segment has been mostly abandoned in favour of
- the track which continues on the west side of US 191
way/16835230/history
- via an intersection on US 191, getting to the continuation of this old road.
way/1076164809/history

I would suggest adding the "abandoned:" lifecycle prefix, as it is still somewhat visible due to the little traffic it may still get. Otherwise, it's suggested to remove it.

Also, please leave a comment on the note mentioned at the top of this comment (and close it once this has been changed or otherwise resolved).

123613119

Be aware using any Google, or incompatibly licensed data for your edits is prohibited.
osm.wiki/FAQ#Why_don't_you_just_use_Google_Maps/whoever_for_your_data?

If any of your contributions are based on or derive from such sources, you should work with the Data Working Group to take proper action -ie. reverting them-.

123902053

*Should be Cillín Hill Centre Car Park

123472469

Sorry if I sound prescriptive, it is not my intention.

123472469

These are only suggestions. You do not have to follow up any of them.

The bounding box coordinates of a changeset are listed as an example of useless information here (part of the first example);
osm.wiki/Good_changeset_comments#Examples
Anyone can see what the bounding box of your changeset is without looking at the changeset comment, as explained in my comment.

123611516

请把 "F**k DWG "部分从你的资料中删除。尊重你的志愿者伙伴/贡献者。这包括DWG。该信息可能被认为是不恰当的,不管你是否审查了一个不恰当的词或打算把它作为一个笑话。

任何人都可以在你的修改集上发表评论,例如询问你所使用的标签是什么意思。这样,其他贡献者可以了解你正在做什么修改,以及你为什么要这样做。
如果你认为一个评论是不恰当的,请向DWG报告。
https://wiki.osmfoundation.org/wiki/Data_Working_Group#I.27ve_seen_a_problem.3B_what_should_I_do.3F

如果你认为你受到了DWG的不公正对待,请参见
https://wiki.osmfoundation.org/wiki/Data_Working_Group#I_feel_that_I_have_been_treated_unfairly_by_DWG

--

Hey 喵耳引力波 ,

Remove the "F**k DWG" section from your profile, please. Respect your fellow volunteers / contributors. This includes the DWG. The message may be considered inappropriate, regardless if you censor an inappropriate word or intend it as a joke.

Anyone can comment on your changeset to for example ask what a tag you are using means. This way, other contributors can understand what changes you are making and why you are making them.
If you think a comment is inappropriate, report it to the DWG;
https://wiki.osmfoundation.org/wiki/Data_Working_Group#I.27ve_seen_a_problem.3B_what_should_I_do.3F

If you think you have been treated unfairly by DWG, see
https://wiki.osmfoundation.org/wiki/Data_Working_Group#I_feel_that_I_have_been_treated_unfairly_by_DWG

Regards,

Daniel

123492903

It is almost always useful to add "added", "changed", or in this case "removed" to your changeset description.
When changing and especially when removing tags, it can be useful to mention the reason why you removed a tag. I'll assume here it is because it is redundant.
This will make it easier for users to understand your changes.

Suggested changeset description:
"Removed is_in tag (redundant)"
(Or simply
"Removed redundant is_in tag")

If it was on an object it shouldn't be on, you could also specify this;
"Changed is_in tag on building to addr tag (incorrect)"
Or,
"Removed is_in tag from building (incorrect, redundant)"

Also, it may be useful to discuss with your community if it is a good idea to create a MapRoulette task to remove this tag from all objects in the area. This way you may get community consensus and if accepted, it would be more efficiently removed.
( See also
osm.wiki/Automated_Edits_code_of_conduct )

123472469

It is good practice to use the same changeset description, regardless of where or when it was made. If it's related to a notable place, you can add it. Otherwise, you can leave the place out.

Just fyi; consider
1) Is it relevant?
Users can click your changeset and see what coordinates it has, simply by briefly closing the changeset and looking at the url bar, or right clicking the map and asking for the location -to some extent-.
2) Does it help identify your changeset?
Users can query for changesets near certain coordinates using the history page, or the monitoring tools listed on wiki.osm.org .
Most users don't associate coordinates with a place.
Changesets adding the same thing in a large bounding box are not tied to places or coordinates. It is well possible that (nearly) none of those changes are anywhere near those coordinates. To identify a changeset, the following are much more useful - most are already available from your changeset by default:
- the changeset number (unique id), on which the user's changes can be seen.
- the user profile on which the user's history can be found.
- the changeset description to describe what was changed and if needed, why it was changed (ie. if there's a new building being constructed).
- hashtags to group changes into projects -or organizations-.
Coordinates or numbers mostly add clutter to changeset descriptions. They don't convey any useful information which can not be found out otherwise -without looking at the contents of the changeset itself-.
As such, it can be considered as spam.

123602874

website should preferably be brand:website or operator:website instead, since it belongs to the chain, not the store itself.

123401446

Congratulations on creating
node/9876543210
node/9876543210

Unfortunately I do not have time to give feedback on all your contributions. From a quick look at your manual changesets, they look ok.

123454321

Congratulations on the 'symmetrical' changeset number 123454321 :-)

Without streets no OpenStreeertsMap. Or OpenStreetMap. The first one doesn't exist by my knowledge.

Regards,

Daniel

123472469

Hey d1sr4n,

Congratulations on changeset/123456789.

Unfortunately I can't review all your contributions.

Feedback;
Changeset comments which are just "tree", or adding numbers ("1", "2", ...) or coordinates, is not very useful for other contributors reviewing your changesets. Use good changeset comments, please
osm.wiki/Good_changeset_comments

Regards,

Daniel

123418389

I have sent you a private welcome message with useful information :)

I unfortunately can't give feedback on all your contributions. At a glance the Fremantle ones look ok.

123419385

Hey and welcome,

I have sent you a private welcome message with useful information :)

Feedback;

node/6687593708
You can seperate values (ie. artists' names) with a semi-colon (";").

(Sidenote: If the artists or the artwork have a wikidata or wikipedia page, you can add a tag ie. artist:wikidata)

Bicycle parkings:
You don't need to add indoor=no (or most tags *=no) to everything, this is redundant information, unless there exists a risk for others to think it is indoor (when it's mapped really close to a wall). covered=yes or covered=no and indoor=yes if true suffices here. With AEDs, they are usually mapped on a wall, so there adding indoor=no is useful.

Guidepost:
Looks ok

See the wiki for information on tags
osm.wiki/wiki/

Regards,

Daniel

123418389

node/9878239217
Name is the name only, so don't add the name "guidepost" on a guidepost, please (unless that is its actual -signed- name)
osm.wiki/Names#Name_is_the_name_only

123402530

Zoek zonder de post code, dan werkt het. Dit is (gerelateerd aan)
https://github.com/osm-search/Nominatim/issues/1452

Kanttekening: Als je de post code zelf zoekt krijg je een resultaat, maar geen OSM object, de postcode staat namelijk niet in OSM, maar is wel bij de zoekmachine bekend (vanuit bestaande adressen)

123330556

1) If something, ie. a runway, is visible on aerial imagery, someone will map it, regardless of what function it serves or what status it has. A status given only by a single (local) government is not verifiable on the ground.
It is true that (cartographic) representation of certain sites, ie. military sites may be deemed illegal by a country's government and therefore may not be mapped by inhabitants of said country, but can be mapped by those not under said country's laws, unless otherwise agreed by the OSM community (see the Ukraine case, where mapping a country in war would likely do more harm to the country than good)
2) To indicate the type of aerodrome, ie. consists of small runways with little to no infrastructure and is usually used by small planes and not used by public transport, the aerodrome is mapped as a seperate node, unless the extent is verifiable, ie. there's physical barriers around the whole site, in which case it is (additionally) mapped as an area
The same goes for the runway, which can be mapped as a way and to which length and width can be specified, though additionally mapping as area is ok.
3) If you have the local knowledge, a compatible source, or done a survey yourself which shows that
- a certain object, i.e. an aerodrome, is private you can add an access=private tag to further specify this
- a certain physical object or i.e. construction work is temporary (ie. yearly construction work, cable-laying), e.g. less than 6 months (what is considered temporary varies..) then -and only then- you can indicate that by instead leaving it unmapped or (may be better in some cases) instead mapping a node or area with a "note" tag to indicate to other mappers the area is only temporary.

1) osm.wiki/Good_practice#Map_what's_on_the_ground

osm.wiki/Verifiability#Subjective_opinions

osm.wiki/Military

osm.wiki/Russian%E2%80%93Ukrainian_war

2) osm.wiki/One_feature,_one_OSM_element

aeroway=aerodrome

3) osm.wiki/Good_practice#Don't_map_temporary_events_and_temporary_features