b-jazz's Comments
| Changeset | When | Comment |
|---|---|---|
| 163384888 | Thanks for the additions. A couple of comments to improve your mapping if you're interested.
You can find more information at the golf_course wiki page: leisure=golf_course#Common_mapping_pitfalls |
|
| 163163098 | That’s sad to hear. They are 100% wrong. Can you point me to where you heard so that I can prevent this misinformation from spreading any further? |
|
| 163259458 | As mentioned in changeset/162300773, you shouldn't be reusing the nodes when the fairways extend all the way around the green. Some sort of fringe should be left or the fairway should come up short and butt up against the green instead of surrounding it. If you need further clarification, please leave a comment here with any questions and I'll be glad to help out. |
|
| 163339578 | The lines that define Fairways and Greens should never intersect or partially overlap each other. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). If there is no obvious fringe, the fairway should butt up against the green and every node between them should be shared. Please read the wiki for visual examples and instructions on how to better map golf courses: leisure=golf_course#Common_mapping_pitfalls |
|
| 163226558 | Hey there Nat,
|
|
| 163163098 | Overlapping fairways and greens is bad, but so is "almost touching". What you should be doing is *sharing* the nodes between the green and the fairway. Take a look at the wiki (leisure=golf_course#Common_mapping_pitfalls) for examples. See way/1361164081 if you want to look at an example. |
|
| 163137912 | Overlapping fairways and greens is bad, but so is "almost touching". What you should be doing is *sharing* the nodes between the green and the fairway. Take a look at the wiki (leisure=golf_course#Common_mapping_pitfalls) for examples. I've gone ahead and fixed way/1361164081 if you want to look at that for an example. |
|
| 163227978 | Thanks for helping with my golf course cleanup project! |
|
| 163132655 | Thanks for helping with my golf cleanup project! |
|
| 163098973 | Please don't break existing fairway relations. You need to read the golf_course wiki first before you make any changes that undo the work of others. Thanks. |
|
| 163068703 | Hi Stykman17, thanks for your contributions. In case you weren't aware, fairways that completely enclose objects like fairways and sandtraps should be turned into multipolygons. See leisure=golf_course#Common_mapping_pitfalls Thanks. |
|
| 163053806 | Hi eschack50, thanks for your contributions. In case you weren't aware, fairways that completely enclose objects like fairways and sandtraps should be turned into multipolygons. See leisure=golf_course#Common_mapping_pitfalls Thanks. |
|
| 163052751 | Hi RoadHog56, thanks for your contributions. In case you weren't aware, fairways that completely enclose objects like fairways and sandtraps should be turned into multipolygons. See leisure=golf_course#Common_mapping_pitfalls Thanks. |
|
| 163051962 | Hi Daskey, thanks for your contributions. In case you weren't aware, fairways that completely enclose objects like fairways and sandtraps should be turned into multipolygons. See leisure=golf_course#Common_mapping_pitfalls Thanks. |
|
| 163034178 | Hi there jemiller, There are some problems with your golf course mapping and I wanted point them out so that you can correct them and map future golf courses abiding by community standards. A very important wiki to read is leisure=golf_course. Two of things I noticed off the bat are that your fairways are intersecting and partially overlapping the greens. There are two ways to properly map these. One is to butt the fairway to the green and share the boundary nodes between the two lines. The other is if you can see a fringe around the green that is similar to the fairway, you should completely surround the green with the fairway and then merge them together by selecting them both and right clicking and selecting merge. The other problem is that you are naming the elements "Hole 18" and such. Those aren't the actual names and your shouldn't use names to describe features. Instead you should use the "ref" tag and set it to "18" and leave the name tag unset. Please let me know if you have any questions. |
|
| 163070754 | Thanks for turning greens/fairways into proper multipolygons! |
|
| 161803479 | Not cool. Don't do this again. |
|
| 162984112 | Hey there ER, thanks for working on golf course contributions for OSM. We appreciate the map getting filled out. There is a problem with how you're mapping though (e.g. way/1363133822). You are making the fairway (and rough) intersect/partial-overlap with the green which isn't how they are supposed to be mapped. You either need to butt the fairway up against the green and share common nodes, or you need to surround the green (if there is visible fringe matching the fairway) and turn the fairway/green pair into a multipolygon ("Merge" features in iD). Please see the wiki for more information: leisure=golf_course and feel free to reach out with any questions you have. Thanks. |
|
| 162995704 | Hi golfboy, Why did you add a second, nearly identical green here: way/1363208624 ? Also, you put two fairway areas next to each other. These should be a single object and the fairway/green should be combined/merged into a multipolygon. Check out the wiki at leisure=golf_course for how to properly map these together. Let me know if you have any questions. |
|
| 162947921 | Thanks for getting back to me mech32. Can you confirm with me that you understand how relationships and multipolygons work? It wasn't quite clear from your comment that you understood that and how to avoid breaking them. Thanks. |