OpenStreetMap logo OpenStreetMap

Changeset When Comment
68449566

I agree with your second statement.

68449566

Ah! That makes a lot more sense. Thanks @trigpoint.

68449566

Thanks for the info DaveF. I was unaware that this was valid information. What software turns those into clickable links? I'll happy correct them to be valid in the future. As for adding them to the bot, I want to keep the bot focused on it's agreed on task. I correct oddities that I see by hand since they are relatively rare.

67900581

I’m not familiar with openlevelup. There are a couple more issues that I’ve noticed with the indoor mapping. I could let you know when I return to my desktop if that helps.

68219075

Hi F4sOWRt, thanks for your contributions to OpenStreetMap. I wanted to let you know about a best practice for drawing parking lot aisles to help you in future mapping. The paths should never cross over themselves or overlap on top of themselves. So parking lots like Honey Creek Mall shouldn't be drawn with a single path, but instead use many individual paths. Maybe break it up into a one path per horizontal line, and then vertical lines that connect each of the horizontal endpoints.

67900581

Shouldn't way/675236748 be a rectangle? Right now, it is just a three sided way that doubles back on itself.

68241731

Hi RileyBaum, I made some improvements to your parking lot area (way/677521666). Let me know what you think.

68195755

Hi there BeccaG. I'm curious to know if there is a reason that there are two farmland ways right next to each other here? It seems like they should be combined into one larger way, right? If there is something I'm missing, please let me know. Thanks.

68198096

URLs without a schema (http/https/etc) will default to http.

68129090

Please go ahead and make necessary updates. I don't know the area, nor the language enough to make updates there.

68000225

@jdcarls2 is correct. In fact, I did silently fix the first couple of mistakes like this that I found. Then I realized it was a pattern of MAJORHIGH to draw areas in this manor. The example I gave might take 2 seconds, but others I saw would take significantly longer and as it has been pointed out, it would be much easier to correct the problem at the source.

Also, I'm truly interested in the "why" it is happening. I'm surprised that iD even allows someone to make this mistake. Maybe a bug should be filed against iD to prevent this in the future.

68000225

Why are you drawing area nodes out of order and making what looks like a twisted figure eight? way/675872765 for example?

67739835

Hi there, can you go back in and fix way/44380254 ? You deleted many of the nodes and broke the way. Thanks.

67650557

FYI, you are double importing the same (sometimes slightly different) shapes for buildings leaving two buildings overlapping each other.

See way/673599110 for an example.

67607359

Hi there doublepar, thanks for adding to OpenStreetMap. I wanted to let you know something about paths that will help you be a better mapper for future paths that you add. When drawing the line, it shouldn't cross over itself, nor overlap itself. What you want to do is start a new path whenever that situation arises. I've gone ahead and cleaned up the gold cart paths here. I hope this helps.

66280629

Hi @Case. I've reverted this changeset and will be looking at the validity of the others that you've made. Please only create OSM features where there are actual on-the-ground features. I saw that a farmer's field had about 20 bike rental shops strewn all over it. I'm not sure what you're trying to accomplish or if this was made in error or maybe you didn't realize this was going to be publicly visible. If I've deleted any valid bike shops, I apologize.

67368774

A manual output review for the changes I'm making is not feasible. There have been tens of thousands of changes and they are very focused. Only website tags with http where that url redirects to an https url are changed. And only the website tag is changed. The volume is too high to manually review this and the change is so very specific that it really doesn't need to be reviewed. The fact that there are other things wrong with an entity shouldn't be the concern of the bot. That will happen all the time and can't be avoided.

I imagine that there are tools already out there that look for improperly formatted things like postal codes and phone numbers and put them up for manual review. Maybe something like KeepRight already does this.

As for the drawbacks of unreviewed automated edits, I'm sure there are many, but I think I've done a pretty good job in keeping the types of changes so laser focused and well defined that it is hard to argue that the changes I'm making are in any way a problem.

As for how often this will affect you, I think the chances are pretty low. I'd love to hear otherwise of course. In the future, it will probably run maybe weekly or monthly. So the chances that someone creates a crappy entry that also happens to have a website that is http that will redirect to https and have this get created and caught by the bot script before you get to it is low.

Also, I'm not sure why you can't simply revert the bot's changeset, and then revert the bad SEO edit. You will be reverting a few other of the changes that the bot has made in that particular changeset, but you shouldn't worry about that, it will remake the changes a week or two later when it goes to process everything again.

Also, at some point, this bot will likely be run across the entire planet. So if you have any ideas (like not modifying brand new entries that are less than a week old), we should definitely work those out.

67368774

Is this just a general venting of frustration, or are you suggesting I should change the behavior of the bot? Maybe not operate on anything object that is younger than a day or week or something?

67359862

I'm not that familiar with the "brand" key outside of gas stations. I was just changing the http to https on the website key. If there is something else you think I should be doing, let me know.

67359862

I don't think `brand` is the right tag to use either way. A `wikipedia` tag could be added, but I still think the website tag is correct in and of itself. I'd prefer to see it be a link specific to that store (maybe a page that lists store hours for that location and whether or not items are in stock), but that's out of scope for the changes I'm making.