SafwatHalaby's Comments
| Changeset | When | Comment |
|---|---|---|
| 178942025 | I generally agree that in some cases tourism=attraction is justified alongside the more specific tag. But is there anything special about that specific boulder סלע השטן (node/9197188592)? For example, please compare it to: I think either they all warrant tourism=attraction (if so, why?), or they all do not. |
|
| 178942025 | Sorry. Minor correction: I misremembered the exact details of the tourism=artwork case. It was slightly different that what I described here but the general points hold. |
|
| 178942025 | A few more pointers: 1. You might have success with a pull request. A while back I've done this with tourism=artwork - when I changed those to tourism=statue it disappeared from IHM, and the IHM guys happily fixed it: https://github.com/IsraelHikingMap/Site/issues/2156 2. If you're more ambitious you might want to map *all* of these occurrences (I don't think there are many problematic cases) and report them. Basically the pattern is: For every feature that is deemed relevant to the end user on IHM, IHM should consume the specific tags and not just the generic one. |
|
| 178942025 | Typo fix: Harel M / zstadler |
|
| 178942025 | Hello! I understand your concern, but tagging for the renderer is bad OSM practice: osm.wiki/Tagging_for_the_renderer I personally think these boulders are a good fit for IHM. If the IHM guys are interested in boulders appearing on the map, they should update their code so that boulders are included. If they are not interested in boulders appearing on the map, then everything is working properly. This happens with many other tags. For example some people tag עגלות קפה as tourism=attraction and when I fix those, they disappear from IHM. In general IHM is problematic with the "tourism=attraction" tag and it's used as a generic bin for everything. I've had a few discussions with IHM/Zstadler about that but no clear resolution was reached. |
|
| 182143401 | There's value in check_date even if you remove taps that don't work; they provide positive confirmation that the tap actually works! Example: You're planning a hike trip and you want a tap along the way. They tap feature has been last updated 2013. Does it work or not? No way to tell. Perhaps you should consider making use of this tag in IHM/Mapeak. |
|
| 184975775 | Welcome to OSM! The change looks good to me. Thank you! The only thing I would advise is being careful with the aerial maps in the Carmel area. Read more about this here. osm.wiki/He:Aerial_imagery_quickstart You might want to check the Israel Wiki here, specifically the basic guidelines: osm.wiki/Israel#The_basics (Also available in Hebrew) |
|
| 179048902 | ביצעתי כמה תיקוני המשך קלילים ב-changeset/185051785 |
|
| 180733338 | I haven't heard back from you so I reverted the Adyghe name in changeset/185051115 |
|
| 180405008 | Thank you! |
|
| 179153013 | Fixed in changeset/185049441 |
|
| 183536892 | שלום יניב, נדמה שמחקת בטעות את סימון רמות מנשה: way/996203102 |
|
| 184436192 | Hi again and thank you very much for the contributions! I am wondering if the "Trailheads" tagging is incorrect. Generally in OSM, only things that are verifiable and are "on the ground" should be tagged - in other words, another mapper passing through should tag this roughly the same. A trailhead tag is typically for something physical like this: osm.wiki/File:Indian_Lake_Trailhead_-_panoramio.jpg But these tags seem more like descriptive names. What do you think? Please check out the basic guidelines too: osm.wiki/HE:Israel |
|
| 184881319 | Hello Eliyahu! I noticed you've lately done quite a few edits in Haifa region and I thought I'd add some comments here. 1. Sometimes you move around roads only slightly, for example at way/937325094 - are you aligning the roads with satellite imagery? Please be very careful with that. The satellite imagery must be aligned first, there is an explanation here: osm.wiki/He:Aerial_imagery_quickstart (english version here: osm.wiki/Aerial_imagery_quickstart) 2. in changeset/183179518 you described t he change as "sidewalks" but it's clearly much more than that. Since you're doing massive changes it would be very helpful to be descriptive. 3. You've added lots of fords, for example here: node/13879138918 Are these existing on the ground? If this is an attempt to silence editor warnings this would not be good practice. I know some of the waterways are auto-imported and poorly mapped, so it's very possible that there are less fords/no fords on the ground and the waterway is slightly different. |
|
| 184004668 | נא להימנע משמות תאוריים כגון "תחילת מסלול". השם הוא שם כפי שהיית רואה אותו על השלט. במקרה הזה מדובר בחניון "שוויצריה הקטנ". |
|
| 182937969 | Hello, this is agreed upon about the community. Due to the complex multilingual nature of Israel, you never know which language to expect in the "name" tag (it would usually be Hebrew or Arabic, but sometimes even Russian or Adyghe) So the name tag is always replicated in some "name:lang". This makes parsing data infinitely easier. Want Hebrew? Parse "name:he". Want the local language? parse "name" |
|
| 180733338 | See also the Israel naming guidelines: osm.wiki/Israel#Naming Specifically: he name=* tag should be used as the primary name, given in a single language selected like this: If there is signage with only one language, or one language more prominent than others (e.g. a shop's sign or a street name sign), use that language. This is the normal rule for name=*.
|
|
| 180733338 | Hello Bertram. Kfar Kama appears to be a Circassian town whose main language is Adyghe (not Ukranian) even on some of the signs. See https://en.wikipedia.org/wiki/Kfar_Kama Note the photos. Do you think this edit might have been an error? |
|
| 182143401 | Hello! You slightly moved node/4866569325 If you've been there physically it's very useful to update check_date for drinking water It gives users a level of confidence regarding the odds of it being operable. Also some on-the-fly editors like Vespucci and Street Complete make use of that date to flag features as possibly stale and needing resurvey. |
|
| 181804389 | Also, check out the basic guidelines here: osm.wiki/WikiProject_Israel#The_basics |