Frank Peng's Comments
| Changeset | When | Comment |
|---|---|---|
| 181104566 | Please make sure to modify the geometry of existing OSM elements instead of deleting them and redrawing them anew. It helps preserve their editing history on OSM.
You deleted a natural=water way and remapped it as a multipolygon relation in this changeset, when you could've copied and removed the tags on the existing natural=water way that you deleted and created a new natural=water multipolygon relation, pasted the deleted way's tags to the multiplygon relation, and added the way to it.
|
|
| 181018326 | Please modify the geometry of the existing buildings instead of deleting them and remapping them anew. It helps preserve their editing history on OSM.
|
|
| 181018115 | I see that you deleted some buildings and remapped them anew in this changeset. Please just modify the geometry of existing buildings on OSM instead of deleting them and remapping them anew. It follows good practice on OSM and helps preserve the element's editing history.
|
|
| 181017425 | Please modify the geometry of existing roads on OSM instead of deleting them and redrawing them anew, in accordance with good practice on OSM.
|
|
| 181017143 | Hello BeaconOSM, I see that you deleted some roads and remapped them anew in this changeset. It's good practice to modify the geometry of existing roads rather than delete them and remap them anew. It helps preserve their editing history on OSM.
|
|
| 181013282 | Please make sure to modify the geometry of the existing map elements instead of deleting them and redrawing them anew. It helps preserve their editing history on OSM.
|
|
| 181011898 | Please note that it is good practice to just modify the geometry of existing roads instead of deleting them and redrawing them anew. It helps preserve their editing history on OSM. See the OSM Wiki article on "Keep the history": osm.wiki/Keep_the_history
|
|
| 180728637 | Roads need to be connected to each other. Otherwise, people can't access them. The service roads you mapped (way/1495143714 and openstreetmap.org/way/1495143715) are very close to each other but not connected to each other. Also, it's good practice to modify the geometry of existing map elements instead of deleting them and remapping them anew. This helps preserve their editing history on OSM. You deleted an existing service road in this changeset (way/19836998/history) and remapped it anew. So it's good practice to modify the geometry of existing roads instead of deleting them and remapping them anew.
|
|
| 180564777 | Thanks!
|
|
| 180528078 | I would consider that this changeset be reverted as it adjusted roads and streams to distorted Bing aerial imagery of this location, which is not aligned with GPS traces. VBMP aerial imagery of this location is not distorted and well aligned with GPS traces, as it's orthoimagery.
|
|
| 180552567 | Also see this link for frequent mistakes on aligning aerial imagery: osm.wiki/Using_aerial_imagery#Frequent_mistakes
|
|
| 180552567 | Again, please make sure to check the OpenStreetMap GPS traces before adding or moving OSM elements. The boundaries of the land use you mapped next to the Wilson Creek Bridge (the high bridge carrying the VTTI Smart Road) don't align with the GPS traces of this location. Aerial imagery may be distorted, causing the buildings, structures, or objects in imagery to appear to skew to the side. Bing imagery of the location underneath the Wilson Creek Bridge is distorted and not in line with the GPS traces, while VBMP orthoimagery of this location is not distorted and aligned with the GPS traces. So it's important to check the GPS traces before adding or moving OSM data.
See my comments in changeset #180528078: changeset/180528078
|
|
| 180529671 | As mentioned previously, make sure to check the GPS traces before adding or modifying OSM objects, so that you will have an understanding of their actual alignment or location on the ground. The boundary of the farmland multipolygon you created in this changeset (relation/20383306) doesn't actually align with the GPS traces of this location.
|
|
| 180528078 | If you check the OpenStreetMap GPS traces of this location, you will find that the alignment of roads and Wilson Creek in Bing imagery of this location is not aligned with the GPS traces. But if you look at VBMP aerial imagery of this location, you will see that the alignment of roads and Wilson Creek at this location is aligned with the GPS traces, reflecting their actual alignment on the ground. So, before adding or moving OSM objects, make sure to check the GPS traces so that you will know their actual alignment or where they actually are on the ground. Aerial imagery may be distorted, which is common in mountainous or hilly areas. Orthoimagery is usually not distorted.
|
|
| 180528078 | Just to make you aware, Bing aerial imagery of this location is distorted, causing Ellett Road and the VTTI Smart Roads Rural Roadway to appear to curve to the east from its actual alignment on the ground passing under the Wilson Creek Bridge (the high bridge carrying the VTTI Smart Road). VBMP aerial imagery of this location is more aligned with GPS traces, as it's orthoimagery, meaning there are little to no tilts in houses, buildings, structures, or other objects in aerial imagery; and no distortions in alignments of roads, paths, sidewalks, railroads, rivers, creeks, streams, and other land features in aerial imagery. If you check Bing imagery of this location, you will see distortions in the alignment of Ellett Road and will find what appear to be squiggly curves on the road in Bing imagery, while the road does not actually curve like that on the ground. But if you check VBMP aerial imagery of this location, the alignment of the roads is more aligned with the GPS traces, and there are no distortions in the alignment of Ellett Road and the VTTI Smart Roads Rural Roadway in imagery, as VBMP imagery is orthoimagery. You will find said roads in line with their actual alignment on the ground in VBMP imagery. So when mapping in this area, I use VBMP Most Recent Imagery and set the imagery offset to "-0.67, 0.82" because VBMP imagery is offset by about 1 meter. Before adding or moving OSM objects, it is important to check the GPS traces, as aerial imagery will, regardless of source, have offsets to the real positions of objects on the ground. While this can be small enough to be ignored, it can be substantially more than GPS errors and change over small areas. Per the "Good practice" OSM Wiki article, it states: > Aerial imagery will, regardless of source, have offsets to the real positions of objects on the ground. While this can be small enough to be ignored, it can be substantially more than typical GPS errors (>> 10 meters) and change over small areas (requiring re-adjustment). It is mandatory that you check this before moving existing OSM data, or adding more. osm.wiki/Good_practice#Align_aerial_imagery_before_tracing We can check the actual placement of roads and other features by checking the GPS traces or tracks. Aerial imagery provides useful assistance in the mapping process, but it can be a bad idea to move map objects created by other mappers just to match them to aerial images. Aerial imagery may be distorted and shifted relative to real object locations, which is common in mountainous areas and hilly areas. Per the OSM Wiki article on "Using aerial imagery", it states: > The exact placement of roads and other features can be assisted by recording GPS tracks on the ground. Aerial images clearly provide useful assistance in the mapping process, but it can be a bad idea to move map objects created by others just to match them to aerial images. Aerial imagery may be distorted and shifted relative to real object locations. > Because there is, in any case (even if Earth was flat), perspective in the picture, objects may appear to skew to the side the higher above the ellipsoid they are, so this affects high-rise buildings, mountains, and roads going up/down hills. Perspective exists because the camera is only above one certain point at any time. The perspective problem can only be countered by taking more overhead pictures per distance, and combining them. To check GPS traces in the iD editor: * Click on the "Background Settings" icon (the layers icon) to the right (or press "B" on your keyboard) to display the right-hand "Background" pane
|
|
| 180520822 | Hey, so just FYI, just to make you aware that the Bing imagery of this location is distorted causing Ellett Road to appear to curve more to the east than it actually does on the ground; and the houses and buildings along Ellett Road, and the VTTI Smart Roads Rural Roadway to appear to lean more to the east than where they're actually located on the ground. This is common in mountainous areas where aerial imagery of mountainous locations are usually distorted, causing the roads, buildings, railroads, rivers, streams, creeks, paths, or other objects in aerial imagery to appear offset from their actual locations. VBMP imagery of this location is more aligned with the GPS traces of this location as it's orthoimagery, meaning the aerial imagery shows little to no tilts in buildings or other objects in aerial imagery, and it's not distorted, showing the roads, rivers, streams, creeks, railroads, paths, buildings, and other objects in their actual locations as they are on the ground. Before adding or moving OSM objects, it is important to check the GPS traces, as aerial imagery will, regardless of source, have offsets to the real positions of objects on the ground. While this can be small enough to be ignored, it can be substantially more than GPS errors and change over small areas. Per the "Good practice" OSM Wiki article, it states: > Aerial imagery will, regardless of source, have offsets to the real positions of objects on the ground. While this can be small enough to be ignored, it can be substantially more than typical GPS errors (>> 10 meters) and change over small areas (requiring re-adjustment). It is mandatory that you check this before moving existing OSM data, or adding more. osm.wiki/Good_practice#Align_aerial_imagery_before_tracing To check GPS traces in the iD editor: * Click on the "Background Settings" icon (the layers icon) to the right (or press "B" on your keyboard) to display the right-hand "Background" pane
|
|
| 180427659 | I'm curious as to why you deleted a residential road (the residential road with the name=* tag of "Tiffany Lane" way/20361042/history) in this changeset. Maybe that road doesn't exist anymore?
|
|
| 162032204 | What was the purpose of this changeset? From what I can see, it looks like you deleted a parking area and remapped it as a multipolygon relation. It also looks like you merged a few sections of roads.
Please make sure to just modify the geometry of existing map elements instead of deleting them and remapping them anew, as it helps preserve an element's editing history on OSM. You could've just modified the geometry of the parking area you deleted in this changeset. Also, don't remove map elements you don't need or don't like.
|
|
| 162370344 | I see that you deleted some service roads and parking aisles in this changeset and remapped them anew, when it's better to just modify the geometry of the existing roads. Modifying the geometry of existing map features instead of deleting them and remapping them anew helps preserve their editing history.
Also, don't remove map features with tags you don't understand or have no meaning to you. Just because you come across map elements with tags that have no meaning to you doesn't automatically mean you should remove them. They may have been added for a specific purpose. I see in this changeset that you deleted a section of service road with the covered=yes tag (way/1314787971/history) and mapped a new parking aisle in its place. If you come across a map element with tags that you don't understand or have no meaning to you, then don't delete them. Check the meaning of a tag by clicking on a map feature in the iD editor, scroll to the "Tags" section at the bottom of the left-hand "Edit feature" pane, click on the info icon (the "i" icon) to the right of the tag, and the meaning of the tag will appear below the respective tag. Click on the "View documentation" hyperlink below the respective tag's meaning to see the OSM Wiki article on the tag.
|
|
| 180312441 | Oh, I see. Well, thanks for responding! This is the first time that we're hearing from you. |