ElliottPlack's Comments
| Changeset | When | Comment |
|---|---|---|
| 85148471 | Good day. Could you explain why you've changed a walking path to a horse path here? The bridleway tag implies only horses are allowed. |
|
| 85144411 | Please review osm.wiki/Good_changeset_comments#How_should_I_write_Changeset_Comments.3F for some examples of how to write a useful changeset comment. |
|
| 85144411 | Hello. This does not look like a fence. |
|
| 73241981 | Hello there. "fix roads" is not at all descriptive of this changeset. Could you explain a little more about what you're doing here? The use of localities as historic sites is unprecedented for the project. Localities are for mapping places of human settlement, not battlefields. We have a tag for that. While the work here at Gettysburg looks nice on OSM, the purpose of the project is to produce useful data for maps, not to make the openstreetmap homepage look good. |
|
| 86585269 | Hello there. Could you be a little more specific in your changeset comments? Every single one has the comment "gettysburg fences" but it doesn't look like you even edited any fences here. Give a few words on what you're doing, e.g. updating roads, adding parking areas, etc. Thanks! |
|
| 85505681 | Got it. I just uploaded the changeset changeset/86574067 The issue here was that the three islands inside the bay were still tagged with coastline. That was surely causing some error with the coastline. All is good now. |
|
| 85505681 | That's the right way. It could be a missing link in the relation or something. I'll take a look and write back. |
|
| 85505681 | Sorry for the delay. It looks like it still needs that natural=water tag to show up as water. The way you had done it (as coastline) is not technically wrong. It was more of a local convention to "switch" these deep coastlines to water multipolygons. I'd consider adding natural=water and water=river, then naming it as Eastern Bay. It is a "river" in so far as upstream water eventually flows through it. But, since the bay is tidal, all of the rivers that are below the fall line could be considered coastline but they typically set to river. Typically i'll add natural=bay as a point when the bay is somewhat indiscriminate. |
|
| 82924351 | Hi, thanks for your contributions of T.Parker Host locations. In this case, there is already a building on the map here, so I've converted your building to a point of interest. It will soon appear on the map for all to see. What kind of work does T. Parker Host do? |
|
| 85505681 | Wikipedia for Eastern Bay https://en.wikipedia.org/wiki/Eastern_Bay |
|
| 85505681 | OK, thanks for the explainer here. If you hit a wall with this kind of complex thing (as I often do) feel free to reach out on the OSM US Slack Group. The original goal here in the Eastern Chesapeake was to add the "eastern bay" as a big multipolygon, rather than a part of the coastline. The coastline, as you may know, is big, complex, and slow to update. We've been encouraged to remove big bays from the coastline to make it easier for mappers to see updates to the water as the rendering happens nearly instantly. I think it's fine to split off the smaller bays from the big eastern bay too. I think it was named Miles River when it should have been Eastern Bay. Since you've already made a bunch of changes here I don't think we should try reverting this, rather let's just fix it. Want to take a crack at putting the bay features into multipolygons and then removing the coastline from all but the most outer ways? |
|
| 85505681 | No, you haven't :) It is missing now. The creation of these bays as relation was done in coordination with the local and international OSM community. What was the problem that you'd hope to fix with these edits? |
|
| 85470880 | Hi there, it looks like you've removed one of the bays here and replaced it with coastline but done so improperly, breaking the coastline. Could you explain the reasoning here? We've decided to remove all water except for the main Chesapeake Bay from the coastline to encourage editing. |
|
| 84496298 | I like that this changeset has a legal citation. |
|
| 62174338 | This is so cool! I came across this little park on a bike ride and never noticed it before. I'm glad you added it to the map. |
|
| 61713839 | Hello there. While looking for a mountain bike relation I mapped some years ago I see that you've changed the route to a hiking route. Why did you do that? The route is a signed, official mountain bike trail and so I added it as such for cyclists to enjoy. Instead of changing route types, please add a copy (if it is indeed a hiking route.) |
|
| 84785297 | See changeset/78746676 for inspiration |
|
| 78746676 | @Atom although your changes were done incorrectly, there is indeed a storm drain tunnel down there. I researched the location and added it to the map in this changeset changeset/84785297 |
|
| 78746676 | Great! yea the connection between the lake goes SW towards the park. |
|
| 78746676 | I took a look at the storm drain data and it does not remotely follow this path. I recommend reverting this changeset and adding the storm drain separately. |